Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward compatibility with PHP 7.4 #32

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Forward compatibility with PHP 7.4 #32

merged 1 commit into from
Oct 30, 2019

Conversation

carusogabriel
Copy link
Contributor

Fix #31.

In PHP 7.4, the json extension now follows the versioning of the current PHP version.
In order to solve the compatibility with PHP 7.4 and bellow, the * can be used as it's
a build-in extension.

@lcobucci lcobucci added this to the 2.1.0 milestone Oct 30, 2019
@lcobucci lcobucci added the Improvement Improvement of existing feature label Oct 30, 2019
lcobucci
lcobucci approved these changes Oct 30, 2019
View reviewed changes
Copy link
Owner

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superb

@carusogabriel @lcobucci
Forward compatibility with PHP 7.4
c50ac95 
In PHP 7.4, the `json` extension now follows the versioning of the current PHP version.
In order to solve the compatibility with PHP 7.4 and bellow, the `*` can be used as it's
a build-in extension.
@lcobucci lcobucci merged commit ff2a905 into lcobucci:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcobucci lcobucci lcobucci approved these changes

Assignees
No one assigned
Labels
Improvement Improvement of existing feature
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

[PHP 7.4] Versioning of ext-json
2 participants
@carusogabriel @lcobucci